[PATCH]: if (cond); foo() in firewire
Gary Jennejohn
gary.jennejohn at freenet.de
Sun Jun 21 16:23:26 UTC 2009
On Sun, 21 Jun 2009 10:20:22 +0200
Roman Divacky <rdivacky at freebsd.org> wrote:
> hi
>
> is this patch correct? may I commit it?
>
> Index: ../../../dev/firewire/fwdev.c
> ===================================================================
> --- ../../../dev/firewire/fwdev.c (revision 194573)
> +++ ../../../dev/firewire/fwdev.c (working copy)
> @@ -443,7 +443,7 @@
> xfer->send.pay_len = uio->uio_resid;
> if (uio->uio_resid > 0) {
> if ((err = uiomove((caddr_t)&xfer->send.payload[0],
> - uio->uio_resid, uio)));
> + uio->uio_resid, uio)))
> goto out;
> }
>
>
> another bug found by the "useless warnings in clang" ;)
>
Certainly looks like it should be corrected. I'd say go ahead
and commit it in my guise as a former src-committer :)
---
Gary Jennejohn
More information about the freebsd-current
mailing list