warnings cause build fail

Alexey Shuvaev shuvaev at physik.uni-wuerzburg.de
Mon Jun 8 13:16:38 UTC 2009


On Mon, Jun 08, 2009 at 02:31:39PM +0200, Gabor Kovesdan wrote:
> Hi,
>
> building yesterday's -current on 7.2-R fails due to -Werror, I can only  
> build it if I set WERROR="". Is this a known issue or is it supposed to  
> build successfully on -stable?
>

SVN rev 193673 on 2009-06-08 02:13:24Z by marcel

Make the size (-s) and start (-b) parameters of the add verb optional.
The missing parameter(s) are automatically filled-in.

Attached patch (probably) solves the issue.

Alexey.
-------------- next part --------------
--- geom_part.c.orig	2009-06-08 15:11:02.000000000 +0200
+++ geom_part.c	2009-06-08 15:11:45.000000000 +0200
@@ -342,13 +342,13 @@
 		return (ENOSPC);
 
 	if (!has_size) {
-		asprintf(&val, "%jd", size);
+		asprintf(&val, "%llu", size);
 		if (val == NULL)
 			return (ENOMEM);
 		gctl_change_param(req, "size", -1, val);
 	}
 	if (!has_start) {
-		asprintf(&val, "%jd", start);
+		asprintf(&val, "%llu", start);
 		if (val == NULL)
 			return (ENOMEM);
 		gctl_change_param(req, "start", -1, val);


More information about the freebsd-current mailing list