gmirror provider name limit [Was: Re: geom_label: gpt/labelname for gmirror provider?]

[Harald Schmalzbauer]

Dimitry Andric schrieb am 16.07.2009 13:30 (localtime):
> On 2009-07-16 09:43, Harald Schmalzbauer wrote:
>> I found that the name of the provider for gmirror mustn't exceed 15 
>> characters. `gmirror` doesn't complain if you specify a provider name 
>> longer that 15 characters, but the mirror won't be detected.
>> So for example it's impossible to use gptid as provider.
>> At least this should be documented in the man page(es, I guess this 
>> restriction applies to graid3 etc. also)
> 
> As far as I can see, this limit applies to gconcat, gjournal, gmirror,
> graid3, gshsec and gstripe:
> 
> sys/geom/concat/g_concat.h:96:	char		md_provider[16]; /* Hardcoded provider. */
> sys/geom/journal/g_journal.h:292:	char		md_provider[16]; /* Hardcoded provider. */
> sys/geom/mirror/g_mirror.h:250:	char		md_provider[16]; /* Hardcoded provider. */
> sys/geom/raid3/g_raid3.h:281:	char		md_provider[16]; /* Hardcoded provider. */
> sys/geom/shsec/g_shsec.h:88:	char		md_provider[16]; /* Hardcoded provider. */
> sys/geom/stripe/g_stripe.h:91:	char		md_provider[16]; /* Hardcoded provider. */

Are there any problems to expect when extending the array size?
To make use og gptid it had to be 43.

Anyone willing to commit a patch?

Thanks,

-Harry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20090728/127cfaf0/signature-0001.pgp