Today build breaks nvidia driver

[Attilio Rao]

2008/9/20, Diego Depaoli <trebestie at gmail.com>:
> Hi all,
>  I've some trouble building nvidia driver after today world/kernel.
>  Here's the log:
>  ===>  Configuring for nvidia-driver-173.14.12
>  ===>  Building for nvidia-driver-173.14.12
>  ===> src (all)
>  @ -> /usr/src/sys
>  machine -> /usr/src/sys/i386/include
>  awk -f @/tools/makeobjops.awk @/kern/device_if.m -h
>  awk -f @/tools/makeobjops.awk @/kern/bus_if.m -h
>  awk -f @/tools/makeobjops.awk @/dev/pci/pci_if.m -h
>  awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -p
>  awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -q
>  awk -f @/tools/vnode_if.awk @/kern/vnode_if.src -h
>  cc -O2 -pipe -fno-strict-aliasing -DNV_VERSION_STRING=\"173.14.12\"
>  -D__KERNEL__ -DNVRM -UDEBUG -U_DEBUG -DNDEBUG -O -Werror -D_KERNEL
>  -DKLD_MODULE -std=c99 -nostdinc  -I/src -I. -I@ -I@/contrib/altq
>  -finline-limit=8000 --param inline-unit-growth=100 --param
>  large-function-growth=1000 -fno-common  -mno-align-long-strings
>  -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2
>  -mno-sse3 -ffreestanding -fstack-protector -fstack-protector -Wall
>  -Wredundant-decls -Wnested-externs -Wstrict-prototypes
>  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
>  -Wno-pointer-sign -fformat-extensions -c nvidia_ctl.c
>  cc -O2 -pipe -fno-strict-aliasing -DNV_VERSION_STRING=\"173.14.12\"
>  -D__KERNEL__ -DNVRM -UDEBUG -U_DEBUG -DNDEBUG -O -Werror -D_KERNEL
>  -DKLD_MODULE -std=c99 -nostdinc  -I/src -I. -I@ -I@/contrib/altq
>  -finline-limit=8000 --param inline-unit-growth=100 --param
>  large-function-growth=1000 -fno-common  -mno-align-long-strings
>  -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2
>  -mno-sse3 -ffreestanding -fstack-protector -fstack-protector -Wall
>  -Wredundant-decls -Wnested-externs -Wstrict-prototypes
>  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
>  -Wno-pointer-sign -fformat-extensions -c nvidia_dev.c
>  cc -O2 -pipe -fno-strict-aliasing -DNV_VERSION_STRING=\"173.14.12\"
>  -D__KERNEL__ -DNVRM -UDEBUG -U_DEBUG -DNDEBUG -O -Werror -D_KERNEL
>  -DKLD_MODULE -std=c99 -nostdinc  -I/src -I. -I@ -I@/contrib/altq
>  -finline-limit=8000 --param inline-unit-growth=100 --param
>  large-function-growth=1000 -fno-common  -mno-align-long-strings
>  -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2
>  -mno-sse3 -ffreestanding -fstack-protector -fstack-protector -Wall
>  -Wredundant-decls -Wnested-externs -Wstrict-prototypes
>  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
>  -Wno-pointer-sign -fformat-extensions -c nvidia_linux.c
>  cc -O2 -pipe -fno-strict-aliasing -DNV_VERSION_STRING=\"173.14.12\"
>  -D__KERNEL__ -DNVRM -UDEBUG -U_DEBUG -DNDEBUG -O -Werror -D_KERNEL
>  -DKLD_MODULE -std=c99 -nostdinc  -I/src -I. -I@ -I@/contrib/altq
>  -finline-limit=8000 --param inline-unit-growth=100 --param
>  large-function-growth=1000 -fno-common  -mno-align-long-strings
>  -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2
>  -mno-sse3 -ffreestanding -fstack-protector -fstack-protector -Wall
>  -Wredundant-decls -Wnested-externs -Wstrict-prototypes
>  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
>  -Wno-pointer-sign -fformat-extensions -c nvidia_os.c
>  cc1: warnings being treated as errors
>  nvidia_os.c: In function 'os_is_administrator':
>  nvidia_os.c:168: warning: implicit declaration of function 'suser'
>  nvidia_os.c:168: warning: nested extern declaration of 'suser'
>  *** Error code 1
>
>  Stop in /usr/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86-173.14.12/src.
>  *** Error code 1
>
>  Stop in /usr/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86-173.14.12.
>  *** Error code 1
>
>  Stop in /usr/ports/x11/nvidia-driver.
>  *** Error code 1
>
>  Stop in /usr/ports/x11/nvidia-driver.
>
>  Thanks in advance

This port needs to be fixed with switching to priv_check() privileges
checking model. The __FreeBSD_version can be used in order to maintain
old code for older version of FreeBSD, if the maintainer thinks it is
necessary.
The maintainer can work with me or Robert Watson in order to do that.

Thanks,
Attilio


-- 
Peace can only be achieved by understanding - A. Einstein