panic mounting ntfs

[Attilio Rao]

2008/5/8, John Baldwin <jhb at freebsd.org>:
> On Tuesday 06 May 2008 11:04:44 pm Josh Carroll wrote:
>  > In doing some data recovery for my brother-in-law, I tried to mount
>  > his win2k partition (NTFS), and the box immediately panic'd. I dd'd
>  > the partition and was able to mount it on my 7.0-RELEASE box (via
>  > mdconfig -t vnode ...), but trying to do that on the -CURRENT box also
>  > panic'd.
>  >
>
> > panic: Assertion (flags & ~LK_INIT_MASK) == 0 failed at
>  > /usr/src/sys/kern/kern_lock.c:298
>  >
>  > And here's the backtrace:
>  >
>
> > #13 0xc54a6b00 in ntfs_ntlookup (ntmp=0xc5467800, ino=0,
>  > ipp=0xe79a47f4) at
>  > /usr/src/sys/modules/ntfs/../../fs/ntfs/ntfs_subr.c:408
>
>
> This should fix it:
>
>  Index: ntfs_subr.c
>  ===================================================================
>  RCS file: /host/cvs/usr/cvs/src/sys/fs/ntfs/ntfs_subr.c,v
>  retrieving revision 1.45
>  diff -u -r1.45 ntfs_subr.c
>  --- ntfs_subr.c 13 Feb 2008 13:02:12 -0000      1.45
>  +++ ntfs_subr.c 8 May 2008 12:36:10 -0000
>  @@ -405,7 +405,7 @@
>
>         VREF(ip->i_devvp);
>
>         /* init lock and lock the newborn ntnode */
>  -       lockinit(&ip->i_lock, PINOD, "ntnode", 0, LK_EXCLUSIVE);
>
> +       lockinit(&ip->i_lock, PINOD, "ntnode", 0, 0);
>
>         mtx_init(&ip->i_interlock, "ntnode interlock", NULL, MTX_DEF);
>         ntfs_ntget(ip);
>

Fix committed.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein