bsnmpd hrProcessorLoad results incorrect on FreeBSD 7 or 8?

[Stanislav A Svirid]

On Wed 07 May, 2008, Harti Brandt wrote:

> On Tue, 6 May 2008, Michael Proto wrote:
> 
> MP>Mike Tancsa wrote:
> MP>> At 08:55 PM 5/6/2008, Michael Proto wrote:
> MP>> > Is anyone seeing problems with bsnmpd reporting an incorrect
> MP>> > HOST-RESOURCES-MIB::hrProcessorLoad value under HEAD? I'm using the
> MP>> > default /etc/snmpd.config settings and am loading the
> MP>> > /usr/lib/snmp_hostres.so library just as I do in 6.3, but the value for
> MP>> > this MIB always reports CPU utilization at 100% regardless of the actual
> MP>> > load on the system. 6.3 and 6-STABLE both work correctly and report the
> MP>> > actual CPU utilization when queried.
> MP>> 
> MP>> IIRC, I noticed this when I changed to ULE from 4BSD_SCHED.
> MP>> 
> MP>>         ---Mike
> MP>> _______________________________________________
> MP>> freebsd-current at freebsd.org mailing list
> MP>> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> MP>> To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
> MP>
> MP>Would match my environment as well, as I'm using ULE on all of the
> MP>affected systems. Just built a 4BSD kernel on my HEAD system and
> MP>HOST-RESOURCES-MIB::hrProcessorLoad reports a correct value again.
> MP>
> MP>Anyone have an idea on a fix?
> 
> If anybody has a fix that works with both schedulers, I happily commit 
> this.

Here you are :)

--- hostres_processor_tbl.c.old	2008-05-07 17:23:47.000000000 +0700
+++ hostres_processor_tbl.c	2008-05-07 17:23:54.000000000 +0700
@@ -120,7 +120,7 @@ static double
 processor_getpcpu(struct kinfo_proc *ki_p)
 {
 
-	if (ccpu == 0 || fscale == 0)
+	if (fscale == 0)
 		return (0.0);
 
 #define	fxtofl(fixpt) ((double)(fixpt) / fscale)

-- 
Stanislav Svirid
> Siberian Networks, Novosibirsk, Russia
> SAS-RIPE, 3909675 at ICQ