shared lock instead of exclusive in set_rootvnode

Roman Divacky rdivacky at freebsd.org
Sun Mar 30 14:50:14 PDT 2008


On Tue, Mar 04, 2008 at 01:15:42PM +0200, Kostik Belousov wrote:
> On Mon, Mar 03, 2008 at 09:09:46PM +0100, Roman Divacky wrote:
> > hi
> > 
> > in set_rootvnode() there is 
> > 
> > p->p_fd->fd_cdir = rootvnode;
> > p->p_fd->fd_rdir = rootvnode;
> > 
> > protected just by FILEDESC_SLOCK(), I dont think this is correct
> > although it might be benign as this is used only during boot.
> > 
> > still, if it's not correct it should be fixed
> > 
> > comments?
> 
> Seems right. Did you boot with patched kernel ?

I've been running with this patch for a month... is it time to commit
this?


More information about the freebsd-current mailing list