patching

[Robert Watson]

On Sat, 22 Mar 2008, Chuck Robey wrote:

> I finally get to the point that I can do some useful coding on some usb 
> stuff, I make up a patch, update current so that I can compile against it, 
> and find that someone has broken current.  Naughty, naughty. Here's the part 
> of kdump where it broke:

Since we don't have a sys/tablet, I'm wondering if it's perhaps your fault 
:-).  Does your include file have appropriate #ifndef/#define/#endif guards 
around it to protect you from syntax errors in the event of multiple (possibly 
nested) include?

Robert N M Watson
Computer Laboratory
University of Cambridge

>
> ===> usr.bin/kdump (all)
> cc -O2 -fno-strict-aliasing -pipe  -I/usr/src/usr.bin/kdump/../ktrace
> - -I/usr/src/usr.bin/kdump -I/usr/src/usr.bin/kdump/../..  -c
> /usr/src/usr.bin/kdump/kdump.c
> cc -O2 -fno-strict-aliasing -pipe  -I/usr/src/usr.bin/kdump/../ktrace
> - -I/usr/src/usr.bin/kdump -I/usr/src/usr.bin/kdump/../..  -c ioctl.c
> In file included from ioctl.c:127:
> /usr/obj/usr/src/tmp/usr/include/sys/tablet.h:93: error: redefinition of 'struct
> synapticshw'
> *** Error code 1
>
> Hope that's of some help.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.4 (FreeBSD)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFH5VvQz62J6PPcoOkRAgBnAJ4jNmThoQmqDyJ/wlv+vqra/5YI/ACffkSo
> 0aN3Hxq0Rwn5HjTDb651Pv0=
> =GLzQ
> -----END PGP SIGNATURE-----
> _______________________________________________
> freebsd-current at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe at freebsd.org"
>