Hard lockup with recent CURRENT when using mount_smbfs -- recursive lock message

[Yuri Pankov]

On Sun, Jun 08, 2008 at 08:48:54PM -0700, Garrett Cooper wrote:
> On Sun, Jun 8, 2008 at 8:39 PM, Garrett Cooper <yanefbsd at gmail.com> wrote:
> > On Sun, Jun 8, 2008 at 7:31 PM, Garrett Cooper <yanefbsd at gmail.com> wrote:
> >> Hi guys,
> >>       First hard lockup in a while.
> >>       Just synced current to latest sources yesterday after having to
> >> apply some patches to get things to cleanly compile. PR's posted at
> >> the bottom of the message.
> >>       When I run the following command:
> >>
> >> optimus# mount_smbfs -I 192.168.10.47 -W WORKGROUP
> >> //gcooper at orangebox/c$ /mnt/smbfs/
> >> Password:
> >>
> >>        My system just locked up. Nothing else that I can say other
> >> than it says the following on the console (and it refuses to let me
> >> login / interrupt the processor):
> >>
> >> smb_co_lock: recursive lock for object 1
> >>
> >>        The kernel hasn't panicked and I don't have any means of
> >> accessing the machine, so I can't capture output from the kernel right
> >> now :(.
> >>
> >>        I'll post my kernel / system stats in a second once I reboot
> >> the machine.
> 
> I've tied down the following issue (recursive lock for ...) to line
> 352 of sys/netsmb/smb_conn.c.
> 
> I'll manually add in a coredump'able statement to get this thing to
> stop before it locks up my system so I can get a backtrace.
> 
> -Garrett

Could the following LOR I'm seeing on recent -current be related?
(no lockups)
mount_smbfs results in:

lock order reversal: (sleepable after non-sleepable)
 1st 0xffffff00579d6a30 smbss ilock (smbss ilock) @ /usr/src/sys/modules/smbfs/../../netsmb/smb_conn.c:304
 2nd 0xffffff00579d6a08 smbss (smbss) @ /usr/src/sys/modules/smbfs/../../netsmb/smb_conn.c:355
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2a
witness_checkorder() at witness_checkorder+0x609
__lockmgr_args() at __lockmgr_args+0x502
smb_co_lock() at smb_co_lock+0x64
smb_co_get() at smb_co_get+0x38
smb_dev2share() at smb_dev2share+0x16b
smbfs_mount() at smbfs_mount+0xf8
vfs_donmount() at vfs_donmount+0xe40
nmount() at nmount+0xa6
syscall() at syscall+0x1bf
Xfast_syscall() at Xfast_syscall+0xab
--- syscall (378, FreeBSD ELF64, nmount), rip = 0x800898d0c, rsp = 0x7fffffffe618, rbp = 0x1ed ---


Yuri