cpuctl(formely devcpu) patch test request

[Stanislav Sedov]

On Thu, 5 Jun 2008 21:55:39 +0100
Rui Paulo <rpaulo at FreeBSD.org> mentioned:

> A couple comments:
> 1) Do you plan to MFC this ? For what older versions of FreeBSD will devcpu be
> shipped?

In fact, I plan to MFC that to all supported FreeBSD versions (6, 7),
as changes are minimal. Until that those versions will be supported
by sysutils/devcpu port.

> 
> 2) in cpuctl_modevent(): perhaps it's better to return ENOMEM instead of
> ENOSYS if malloc() fails and ENXIO instead of ENOSYS if MSR functionality is
> not present

I fully agree on ENOMEM (thanks for noticing that), while I think that
returning ENOSYS for MSR-less systems is more correct, as it states that
required functionality isn't implemented for this hardware.
 
> 3) I don't mean to impose, but this code needs some small style cleanup,
>    namely: characters above the 80 column, second level indents are four
>    spaces"

Good catch! Fixed.

The updated patch is available at
http://www.springdaemons.com/stas/cpuctl.2.diff

-- 
Stanislav Sedov
ST4096-RIPE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20080605/a9fa2f1f/attachment.pgp