powerd adaptive mode latching

Nate Lawson nate at root.org
Mon Jan 14 11:44:30 PST 2008


Nate Lawson wrote:
> Stefan Lambrev wrote:
>> Nate Lawson wrote:
>>> I am not sure this patch should be committed as-is.  It might be better
>>> centralized in the cpufreq mid-layer so that all drivers benefit instead
>>> of just acpi_perf.  If there are frequencies that are too close to each
>>> other (no matter what the source driver), it might be good to eliminate
>>> them.
>>>
>>> I'll look into it later today.
>>>
>>> -Nate
>>>   
>> I fully agree that centralized solution is better.
>> But at this late stage of RELENG_7_0, I'm happy with this patch, as it
>> solves our problem and is very simple.
>> If you can come with something better before 7-RELEASE, it's OK, but
>> otherwise I think we should have this patch in the CVS and then
>> RELENG_7_0 (even marked as XXX)
>>
>> The other patch actually is in powerd.c and with it doesn't matter what
>> is the source of the information, but I personally, more like the
>> acpi_perf patch :)
> 
> Some of us have other jobs that have nothing to do with FreeBSD.
> Anyway, attached is the patch (compile tested).  You should test without
> the acpi_perf patch to be sure it is functionally equivalent.

Please test the patch.  I need at least one "it works" from someone who
has duplicated cpufreq states to commit it to -current.  Be sure to
first remove any acpi_perf patch that you previously applied.  Thanks.

-- 
Nate


More information about the freebsd-current mailing list