Improving the handling of PR:s

Igor Mozolevsky igor at hybrid-lab.co.uk
Fri Jan 11 15:20:28 PST 2008


On 11/01/2008, Bernd Walter <ticso at cicely12.cicely.de> wrote:

> Another point about hardware is that a patch might influence other
> hardware handled by the same driver, which can't be verified by the
> submitter nor the committer.
> This is especially true with workarounds, which might only be required
> for specific chip revisions.

Which can only be verified/fixed once the patch is merged into a
branch and new PRs are filed, if everyone used the approach of "let's
not touch it because something might go wrong", nobody would fly
because they might be involved in a plane-crash (of a similar model of
a plane, just slightly different configuration)...

The procedure would be effectively:

patch->commit->[fixed|PR->limit the scope of the patch->commit]+

Drawback: more work for the committers.
Advantages: people feel rewarded for contributing patches, more
hardware support...


Voila!

Igor :-)


More information about the freebsd-current mailing list