Shooting sysinstall/SADE geometry warning in the head

[David O'Brien]

It seems Sysinstall and SADE are ingorant of today's disk geometries.
Is there good reason to not make this change?  I've been getting the
gratitious

+----------------------------- Message -----------------------------+
|WARNING:  A geometry of 290721/16/63 for ad8 is incorrect.  Using  |
|a more likely geometry.  If this geometry is incorrect or you      |
|are unsure as to whether or not it's correct, please consult       |
|the Hardware Guide in the Documentation submenu or use the         |
|(G)eometry command to change it now.                               |
|                                                                   |
|Remember: you need to enter whatever your BIOS thinks the          |
|geometry is!  For IDE, it's what you were told in the BIOS         |
|setup. For SCSI, it's the translation mode your controller is      |
|using.  Do NOT use a ``physical geometry''.                        |
+-----------------------------------------------------------(100%)--+
|                           [  OK  ]                                |
+---------------------[ Press enter or space ]----------------------+

warning from just about every usage of sysinstall/SADE over the past
few years.


Index: disks.c
===================================================================
--- disks.c	(revision 186498)
+++ disks.c	(working copy)
@@ -121,9 +121,6 @@ print_chunks(Disk *d, int u)
 	Total += chunk_info[i]->size;
 #ifdef PC98
     if (d->bios_cyl >= 65536 || d->bios_hd > 256 || d->bios_sect >= 256) {
-#else
-    if (d->bios_cyl > 65536 || d->bios_hd > 256 || d->bios_sect >= 64) {
-#endif
 	dialog_clear_norefresh();
 	msgConfirm("WARNING:  A geometry of %lu/%lu/%lu for %s is incorrect.  Using\n"
 		   "a more likely geometry.  If this geometry is incorrect or you\n"
@@ -137,6 +134,7 @@ print_chunks(Disk *d, int u)
 	  d->bios_cyl, d->bios_hd, d->bios_sect, d->name);
 	Sanitize_Bios_Geom(d);
     }
+#endif
     attrset(A_NORMAL);
     mvaddstr(0, 0, "Disk name:\t");
     clrtobot();


-- 
-- David  (obrien at FreeBSD.org)
Q: Because it reverses the logical flow of conversation.
A: Why is top-posting (putting a reply at the top of the message) frowned upon?
Let's not play "Jeopardy-style quoting"