RFC: small syscons and kbd patch

Garrett Cooper yanefbsd at gmail.com
Thu Dec 4 03:24:29 PST 2008

On Tue, Dec 2, 2008 at 5:01 PM, Maksim Yevmenkin
<maksim.yevmenkin at gmail.com> wrote:
> Dear Hackers,
> can someone please review the attached small patch for syscons and
> kbd? it should be a no-op mostly. the patch basically does
> 1) removes bogus layering in syscons, i.e. basically removes sccngetch();
> 2) implements advisory lock for kbd (based on atomic(9));
> 3) implements new POLLED flag for kbd;
> this is a part of a plan to fix keyboard access races in syscons.
> thanks,
> max

     Why are you double and triple negating on this line?

+	return (atomic_cmpset_acq_int(&kbd->kb_locked, !!!on, !!on));


More information about the freebsd-current mailing list