Call for Testers: dialog 1.1-20070930 update
Doug Barton
dougb at FreeBSD.org
Sun Oct 21 15:13:40 PDT 2007
On Thu, 18 Oct 2007, Jose Alonso Cardenas Marquez wrote:
> 2007/10/17, Doug Barton <dougb at freebsd.org>:
>> If you can make some patches against HEAD I'd be glad to give them a try,
>> but I lack the time to integrate them myself right now.
>>
>
> Done, could you see again?
Ok, I'm trying this again, and I have a few comments. First about your
patches ... it would be better if you could use 'cvs diff' to generate
them, as it would avoid a few issues. The worst of which is that you
included the CVS directories in your patches for -current which created a
lot of drama in my checked out tree.
The second thing I've come up against so far is while trying to build this
stuff as part of a world build it fails in the library build phase because
in the libdialog Makefile it tries to install files to
/usr/obj/src/tmp/usr/share/examples/libdialog which doesn't exist. I'm not
enough of a bmake expert to tell you how to get it to create an extra OBJ
directory for you, but I'm sure someone can. :) I got around this issue
with brute force, I created the directory by hand.
The next problem with your patch is that the dialog patch for the Makefile
has SRCDIR as */libdialog.new. That was easily corrected.
As for problems with buildworld, in addition to the problems you mentioned
with sysinstall (which I'm ignoring) there is also a libdialog dependency
in usr.sbin/tzsetup. I can add the following to the Makefile to avoid
having it fail when it can't find dlg_config.h (which may or may not be
the right solution):
-CFLAGS+= -I${.CURDIR}
+CFLAGS+= -I${.CURDIR} -I${.CURDIR}/../../gnu/lib/libdialog
But the build for tzsetup will still fail because it expects the old
version of libdialog. (Please note that there may be other victims here as
well, I have a not of NO_FOO knobs in my make.conf for my everyday
system.)
The build for usr.sbin/sade also fails, but I think that may have been
part of what you were referring to in regards to sysinstall?
Ok, now for the good news! After getting it built and installed I ran
through every single OPTIONS dialog for the ports that I have installed,
plus a few other things (pkg-install messages), and it works great. I
particularly like the fact that you can now press the enter key to select
"yes" without having to tab to it.
So I definitely think you're on the right track here, although there is
obviously some work to go.
hth,
Doug
--
This .signature sanitized for your protection
More information about the freebsd-current
mailing list