sshd broken with UsePrivilegeSeparation=yes on sparc64

[Poul-Henning Kamp]

In message <Pine.GSO.4.64.0707151732540.129 at neerbosch.nijmegen.internl.net>, Mi
chiel Boland writes:
>It looks like gcc mis-compiles /usr/src/crypto/openssh/monitor_fdpass.c on 
>sparc64. For some reason it optimizes away the assignment of fd on line 
>132:
>
>         fd = (*(int *)CMSG_DATA(cmsg));
>
>So, obviously a gcc bug. I will try to generate a smaller test-case for 
>this.

I'm not convinced that CMSG_DATA is entirely kosher.

FlexeLint (www.gimpel.com) have complained about CMSG_DATA for ages
but I have never been able to figure out why it complained.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.