[RFC, PATCH] Getting rid of direct calls to keyboard's methods via kbdsw[] array

Marcel Moolenaar xcllnt at mac.com
Sat Dec 22 10:56:49 PST 2007


On Dec 21, 2007, at 8:01 PM, Wojciech A. Koszek wrote:

> My proposal is to unify a way in which we call such specialized
> methods, so that instead of direct array indexing used to call  
> specific
> keyboard method:
>
> 	(*kbdsw[(kbd)->kb_index]->enable)((kbd))
>
> We would use unified interface:
>
> 	kbdd_enable(kbd)
>
> Proposed patch is here:
>
> 	http://people.freebsd.org/~wkoszek/patches/tty/kbdcleanup.patch
>
> Suggestions are welcome.

I like it. It would be nice to be able to get rid of the 2nd 'd'
in the kbdd_ prefix though...

FYI,

-- 
Marcel Moolenaar
xcllnt at mac.com




More information about the freebsd-current mailing list