off-by-one error in sbin/atm
Roman Divacky
rdivacky at freebsd.org
Sat Apr 14 16:31:49 UTC 2007
On Sat, Apr 14, 2007 at 08:09:40PM +0400, Maxim Konovalov wrote:
> On Sat, 14 Apr 2007, 17:42+0200, Roman Divacky wrote:
>
> > hi
> >
> > in /usr/src/sbin/atm/atmconfig/diag.c on line 871 there's
> > off-by-one error. array of size IFNAMSIZ is being written
> > on IFNAMSIZ, ie. one byte after the array.
> >
> > this code
> > ifr.ifr_name[IFNAMSIZ] = '\0';
> > should be
> > ifr.ifr_name[IFNAMSIZ-1] = '\0';
> >
> > thnx for fixing it :)
>
> fixed, thanks.
thnx, that was fast :) just a note.. this was found by compiling
world using gcc43. I wonder how many more I'll find :)
More information about the freebsd-current
mailing list