recent commits break via 8235 ata
nate at root.org
Tue Apr 10 20:32:12 UTC 2007
Giorgos Keramidas wrote:
> On 2007-03-27 12:27, John Baldwin <jhb at freebsd.org> wrote:
>> If that is the case it's because code was using
>> rman_get_bus(handle|tag) on a resource that wasn't activated yet which
>> wouldn't have worked before the nexus changes either. Well, the bus
>> tag might have been right, but the handle for SYS_RES_MEMORY would
>> have been wrong.
> This is the change which stops snd_hda from working here:
> % Date: Wed, 21 Mar 2007 15:39:12 +0000 (UTC)
> % Message-Id: <200703211539.l2LFdCQW036704 at repoman.freebsd.org>
> % From: John Baldwin <jhb at freebsd.org>
> % Subject: cvs commit: src/sys/dev/acpica acpi.c
> % To: src-committers at freebsd.org, cvs-src at freebsd.org, cvs-all at freebsd.org
> % Cc:
> % jhb 2007-03-21 15:39:12 UTC
> % FreeBSD src repository
> % Modified files:
> % sys/dev/acpica acpi.c
> % Log:
> % Change acpi's handling of suballocating system resources to be a little
> % simpler. It now can just use rman_is_region_manager() during
> % acpi_release_resource() to see if the the resource is suballocated from
> % a system resource. Also, the driver no longer needs MD knowledge about
> % how to setup bus space tags and handles when doing a suballocation, but
> % can simply rely on bus_activate_resource() in the parent setting all that
> % up.
> % Revision Changes Path
> % 1.233 +39 -55 src/sys/dev/acpica/acpi.c
> If I update my kernel sources to Wed Mar 21 14:39:39 2007 +0000
> (including the sys/modules/padlock/Makefile commit of Sam Leffler, to
> fix the kernel build from Wed Mar 21 17:37:13 2007 +0000), I can see
> that the snd_hda driver probes my sound card correctly.
> Updating after the commit shown above, breaks snd_hda.
I just finished a binsearch and can verify this exact commit causes the
problem for my ATA also. I'll spend some more time debugging it later.
John, can I back out rev 1.233 of acpi.c until you return since it
prevents some machines from booting?
More information about the freebsd-current