[PATCH] Problem with src/sys/dev/sound/pcm/mixer.c rev. 1.50

[David Wolfskill]

During today's CURRENT build, I encountered:

>>> stage 3.2: building everything
...
cc -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -fformat-extensions -nostdinc -I-  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror  /usr/src/sys/dev/sound/pcm/feeder_volume.c
cc -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -fformat-extensions -nostdinc -I-  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror  /usr/src/sys/dev/sound/pcm/mixer.c
/usr/src/sys/dev/sound/pcm/mixer.c: In function `mixer_oss_mixerinfo':
/usr/src/sys/dev/sound/pcm/mixer.c:761: warning: 'd' might be used uninitialized in this function
*** Error code 1

Stop in /common/S4/obj/usr/src/sys/LAPTOP_30W.
*** Error code 1

Stop in /usr/src.
*** Error code 1

Stop in /usr/src.


This was with rev. 1.50 of src/sys/dev/sound/pcm/mixer.c.

I'm not sure the following patch is correct, but making this change did
allow the kernel to build, install, and boot, which seemed an improvement
at the time:

Index: sys/dev/sound/pcm/mixer.c
===================================================================
RCS file: /cvs/freebsd/src/sys/dev/sound/pcm/mixer.c,v
retrieving revision 1.50
diff -u -r1.50 mixer.c
--- sys/dev/sound/pcm/mixer.c	23 Sep 2006 20:45:47 -0000	1.50
+++ sys/dev/sound/pcm/mixer.c	24 Sep 2006 16:38:54 -0000
@@ -770,6 +770,7 @@
 	if ((mi->dev == -1) && (i_dev->si_devsw != &mixer_cdevsw))
 		return EINVAL;
 
+	d = NULL;
 	m = NULL;
 	t_cdev = NULL;
 	nmix = 0;


Peace,
david
-- 
David H. Wolfskill				david at catwhisker.org
Believe SORBS at your own risk: 63.193.123.122 has been static since Aug 1999.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20060924/60a018f9/attachment.pgp