bge(4) on BCM 5752 A02 panic due to media autoselect

[Sam Leffler]

David Christensen wrote:
>>> Driver fails to start with diagnostic:
>>> bge0: RX CPU self-diagnostics failed!
>> As a followup, I tried backing out only the latest bge(4) changes and
>> now the system (sledge.freebsd.org) works again.  Basically the system
>> responded to ICMP ping, but it seemed all other network trafic didn't
>> work, at least NFS mounts, NTP etc. failed at boot and ssh to the
>> system didn't work.
>>
>> It now works with:
>>
>>      $FreeBSD: src/sys/dev/bge/if_bge.c,v 1.140 2006/08/24 
>> 14:41:16 oleg Exp $
>>      $FreeBSD: src/sys/dev/bge/if_bgereg.h,v 1.52 2006/08/23 
>> 11:32:54 glebius Exp $
>>
>> I can test patches if needed.
>>
> 
> I tried several 5702 NICs with various revisions and was never able to
> duplicate the problem you're seeing.  They all worked correctly with my
> first patch.
> 
> Can you test the attached patch?  I've simply removed the test
> altogether.
> The Linux driver doesn't perform this test and the fact that the test is
> performed after bge_reset() is called simply means we're checking the
> same
> information twice (i.e. did the NIC firmware load).  Since the firmware
> handshake was successful we know the firmware loaded so the test is
> redundant.

This appears to fix problems I was seeing on a 5703 part (sorry David,
told you 5702 before):

bge0: <Broadcom BCM5703 A2, ASIC rev. 0x1002> mem 0xfaff0000-0xfaffffff
irq 11 at device 0.0 on pci2

This is a Dell 600m.  Prior to the patch I'd get the RX diagnostic
failed msg.  dhclient would fetch a lease but I couldn't mount an nfs
volume (w/ UDP).  With your patch things appear to work as before.

	Sam