Take 2: new IP Checksum Code from DragonFlyBSD

[Andrew Gallatin]

Alexander Leidinger writes:
 > Quoting Andrew Gallatin <gallatin at cs.duke.edu> (Thu, 25 May 2006 12:20:17 -0400 (EDT)):
 > 
 > > If we're going to do anything,  I'd prefer to see us skip
 > > the checksum on everything sent across lo0 and stick with
 > > the slower, yet known to work, existing checksum code for
 > > slow interfaces.
 > 
 > The current code is known to work with the current gcc we use. It is
 > known to *not* work with the Intel C compiler. It may or may not work
 > with an upcomming gcc version.
 > 
 > The current code is a maze of assembly and macros, the new one is
 > straight forward C and a little bit of assembly. And the new one is
 > also known to work in DragonFlyBSD. Do you expect *this* code to act
 > differently between FreeBSD and DragonFlyBSD?

If it is is really known to work and it is higher quality, then it is
fine with me.  The original poster presented the new code as a
performance enhancement over the old.  My position is simply that that
the performance of the software checksumming code is irrelevant, as it
should never be used in a situation where performace is important. All
1Gb and 10Gb nics do hardware checksum offload, and we should not be
checksumming local traffic.

Drew