small patch for ngctl

[Gleb Smirnoff]

On Mon, May 22, 2006 at 01:18:27PM +0900, Ganbold wrote:
G> Harti Brandt wrote:
G> >On Fri, 19 May 2006, Ganbold wrote:
G> >
G> >G>Gleb Smirnoff wrote:
G> >G>> On Fri, May 19, 2006 at 05:04:25PM +0900, Ganbold wrote:
G> >G>> G> I see. How can I make system to send unexpected messages to ngctl?
G> >G>> 
G> >G>>   
G> >G>> > kldload ng_ether
G> >G>> > ngctl
G> >G>> >     
G> >G>> 
G> >G>> + ls
G> >G>> There are 2 total nodes:
G> >G>>   Name: ngctl990        Type: socket          ID: 00000004   Num 
G> >hooks: 0
G> >G>>   Name: fxp0            Type: ether           ID: 00000002   Num 
G> >hooks: 0
G> >G>> + connect fxp0: qqq lower
G> >G>> + Rec'd data packet on hook "qqq":
G> >G>> 0000:  00 10 a4 89 56 3f 00 30 48 80 34 83 08 00 45 00  
G> >....V?.0H.4...E.
G> >G>> 0010:  05 dc a0 91 20 00 40 11 91 7a 51 13 40 70 51 13  .... 
G> >. at ..zQ.@pQ.
G> >G>> 0020:  40 6f 08 01 03 27 20 88 9b c6 77 90 1f ee 00 00  @o...' 
G> >...w.....
G> >G>> 0030:  00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
G> >................
G> >G>> 0040:  00 00 00 00 00 00 00 00 00 01 00 00 00 01 00 00  
G> >................
G> >G>> 0050:  01 a4 00 00 00 01 00 00 03 e8 00 00 00 00 00 00  
G> >................
G> >G>> 
G> >G>>   
G> >G>It receives bunch of stuffs with patched ngctl:
G> >G>
G> >G>+ ls
G> >G>There are 3 total nodes:
G> >G> Name: ngctl3919       Type: socket          ID: 00000005   Num hooks: 1
G> >G> Name: fxp0            Type: ether           ID: 00000003   Num hooks: 1
G> >G> Name: re0             Type: ether           ID: 00000002   Num hooks: 0
G> >G>+ connect re0: qqq lower
G> >G>ngctl: send msg: File exists
G> >G>+ connect re0: qqqq lower
G> >G>+
G> >G>Rec'd data packet on hook "qqqq":
G> >G>0000:  ff ff ff ff ff ff 00 14 6c 2e 23 71 08 00 45 00  ........l.#q..E.
G> >G>0010:  00 4e 17 32 00 00 80 11 a0 e2 c0 a8 00 3b c0 a8  .N.2.........;..
G> >G>0020:  00 ff 00 89 00 89 00 3a 9b d7 80 8d 01 10 00 01  .......:........
G> >G>0030:  00 00 00 00 00 00 20 45 43 45 42 46 45 45 45 46  ...... ECEBFEEEF
G> >G>0040:  46 45 4d 45 42 45 4e 43 41 43 41 43 41 43 41 43  FEMEBENCACACACAC
G> >G>0050:  41 43 41 43 41 43 41 00 00 20 00 01              ACACACA.. ..
G> >G>Rec'd data packet on hook "qqqq":
G> >G>0000:  ff ff ff ff ff ff 00 14 6c 2e 28 9d 08 06 00 01  ........l.(.....
G> >G>0010:  08 00 06 04 00 01 00 14 6c 2e 28 9d c0 a8 00 07  ........l.(.....
G> >G>0020:  00 00 00 00 00 00 c0 a8 00 3b 00 00 00 00 00 00  .........;......
G> >G>0030:  00 00 00 00 00 00 00 00 00 00 00 00              ............
G> >G>+
G> >G>Rec'd data packet on hook "qqqq":
G> >G>0000:  ff ff ff ff ff ff 00 14 6c 2e 23 71 08 00 45 00  ........l.#q..E.
G> >G>0010:  00 4e 17 47 00 00 80 11 a0 cd c0 a8 00 3b c0 a8  .N.G.........;..
G> >G>0020:  00 ff 00 89 00 89 00 3a 9b d8 80 8e 01 10 00 01  .......:........
G> >G>0030:  00 00 00 00 00 00 20 45 43 45 42 46 45 45 45 46  ...... ECEBFEEEF
G> >G>0040:  46 45 4d 45 42 45 4e 43 41 43 41 43 41 43 41 43  FEMEBENCACACACAC
G> >G>0050:  41 43 41 43 41 41 41 00 00 20 00 01              ACACAAA.. ..
G> >G>+
G> >G>Rec'd data packet on hook "qqqq":
G> >G>0000:  ff ff ff ff ff ff 00 14 6c 2e 23 71 08 00 45 00  ........l.#q..E.
G> >G>0010:  00 4e 17 4e 00 00 80 11 a0 c6 c0 a8 00 3b c0 a8  .N.N.........;..
G> >G>0020:  00 ff 00 89 00 89 00 3a b1 dc 80 8f 01 10 00 01  .......:........
G> >G>0030:  00 00 00 00 00 00 20 45 4f 45 42 46 44 45 42 45  ...... EOEBFDEBE
G> >G>0040:  42 43 41 43 41 43 41 43 41 43 41 43 41 43 41 43  BCACACACACACACAC
G> >G>...
G> >G>
G> >G>Is it what it supposed to handle?
G> >
G> >Yes. Nice. That's a feature I was missing for a long time.
G> >  
G> Did you test this patch by any chance? Is there any issue with it to be 
G> not committed?
G> Please let me know.

I will review and commit soon.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE