Please help reviewing ! Got another crash because of the ttymodem() / ttyclose() race

John Baldwin jhb at freebsd.org
Tue Jul 11 01:15:53 UTC 2006


On Saturday 08 July 2006 02:44, Martin Blapp wrote:
> >
> > Ok, fixed. Does it look better now ?
> >
> 
> here's the link again.
> 
> http://mx.imp.ch/patches/patch-tty.t_pgrp.diff

You can't lock tp->t_pgrp before you check it for NULL!  Seriously, the
solution is to make sure Giant is held everywhere that t_pgrp is
accessed for now.

-- 
John Baldwin


More information about the freebsd-current mailing list