System call munmap returning with the following locks held: Giant

Suleiman Souhlal ssouhlal at
Wed Jan 18 17:31:13 PST 2006


John Baldwin wrote:
> I sent this to you on IRC, but for the archives, here's a possible fix.  It 
> looks like vm_object_deallocate() never unlocks Giant if it locks it, and the 
> leak would only happen if mpsafevfs=0 or you are using a non-safe filesystem:

The real problem is that vm_object_deallocate() doesn't expect the 
object's type to change if it sees it's a vnode, when it's not holding 
the object lock:
      * In general, the object should be locked when working with
      * its type.  In this case, in order to maintain proper lock
      * ordering, an exception is possible because a vnode-backed
      * object never changes its type.
      vfslocked = 0;
      if (object->type == OBJT_VNODE) {
          struct vnode *vp = (struct vnode *) object->handle;
          vfslocked = VFS_LOCK_GIANT(vp->v_mount);
      if (object->type == OBJT_VNODE) {

The comment is actually wrong, and the object's type can change to 
OBJT_DEAD when the corresponing vnode gets freed, so maybe you might 
want to change it.

-- Suleiman

More information about the freebsd-current mailing list