Bad code in rcorder(8) (Was: Re: New RCorder: abi loaded too late)

[Divacky Roman]

On Tue, Feb 21, 2006 at 05:44:04PM -0800, Doug Barton wrote:
> Ulrich Spoerlein wrote:
> 
> >> Divacky Roman wrote:
> >>> I tried running rcorder under valgrind and it showed me massive
> >>> leaks/double-frees etc. unfortunately I am not able to run valgrind on recent
> >>> 7-current (when I start it it just creates 2.8G coredump)
> 
> > Looks fine to me ...
> 
> I think the trick is to repeat your test with some bad stuff in the scripts.
> So, create some circular dependencies, and some other impossible conditions,
> then repeat the test.
 
yes... I tried running valgrind on circular dependancies... that showed some
mem leaks.... see http://www.freebsd.org/cgi/query-pr.cgi?pr=91789, I got that
leaks when investigating this PR (iirc)
 
> Also, Divacky posted a PR with a start to cleaning up the code, might be
> worth some before and after on that.
> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/93630

my patch doesnt solve any such problems. its just a little cleanup I did when
looking at the code.