buglets with pts - with patch

Michal Mertl mime at traveller.cz
Thu Feb 2 15:30:01 PST 2006


I found a couple of display issues with the new pts type ptys.

wall and who - don't check the utmp tty validity (see also PR bin/84041)
	The attached patch duplicates the check from the w program in who and
wall. For some reason closed pts ttys are displayed/printed to when
there wasn't a problem with the old pty implementation.

ps - the TT column displays garbage (always "pts")
	The attached patch trims "pts/" from the tty name. The printout doesn't
look nice ("10443 pts  IWs    0:00,00 bash" changes to "10443   3  IWs
0:00,00 bash") but the field width is 4 which doesn't allow much. The
right solution would probably involve removing TT column and always use
the longer version TTY with width of 8 (which allows to correctly
display "pts/3"). I checked Solaris 10 and it displays the full tty name
by default.

Regards

Michal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wall.diff
Type: text/x-patch
Size: 862 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20060203/ee53a1da/wall.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: who.diff
Type: text/x-patch
Size: 1090 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20060203/ee53a1da/who.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ps.diff
Type: text/x-patch
Size: 550 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20060203/ee53a1da/ps.bin


More information about the freebsd-current mailing list