Call for e1000phy(4) testers.
Pyun YongHyeon
pyunyh at gmail.com
Mon Dec 4 02:48:19 PST 2006
On Mon, Dec 04, 2006 at 07:39:31PM +0900, To John Baldwin wrote:
> On Fri, Dec 01, 2006 at 01:59:07PM -0500, John Baldwin wrote:
> > On Friday 01 December 2006 07:43, Pyun YongHyeon wrote:
> > > On Fri, Dec 01, 2006 at 03:46:36PM +0800, Tai-hwa Liang wrote:
> > > > On Tue, 28 Nov 2006, Pyun YongHyeon wrote:
> > > > >Hi,
> > > > >
> > > > >I had been writing msk(4) for FreeBSD and realized that e1000phy(4)
> > > > >is buggy on newer Marvell PHYs. For example, manual media selection
> > > > >didn't work at all and I had to stick to autoselection of the media
> > > > >type. The Marvell PHYs are widely used on various NICs including
> > > > >em(4), stge(4), sk(4), msk(4) and nfe(4). Except em(4) which does
> > > > >not support MII layers, correct operation of e1000phy(4) is very
> > > > >important to get a good link with link partner and to report link
> > > > >state changes to upper layers(e.g. dhclinet(8)).
> > > >
> > > > Thank you for working on this.
> > > >
> > > > >With this patch you should be able to set a media type without
> > > > >relying on autoselection and it should supports automatic crossover
> > > > >for all known Marvell PHYs. I've tried hard not to break existing
> > > > >behaviour(e.g. Fiber transceivers) but I can't verify that as I
> > > > >don't have any NICs that have Marvell Fiber transceivers. The patch
> > > > >is somewhat ugly in that it should read a PHY ID register in several
> > > > >palces. It seems that there is no easy way to avoid the reading until
> > > > >we have PHY model/revision numbers in mii softc.
> > > > >
> > > > >If you are one of users that use stge(4), sk(4), msk(4) and nfe(4)
> > > > >please test and report any strange things not observed on stock
> > > > >version.
> > > > >
> > > > >Note for nfe(4) users:
> > > > >It seems that nfe(4) has bugs that it can't send packets on
> > > > >half-duplex media(I've got "tx v1 error 0x6004"). I guess this comes
> > > > >from mismatches between PHY and MAC. So you may have to set
> > > > >full-duplex on nfe(4) until we have a fix for the issue.
> > > > >
> > > > >You can get the latest e1000phy(4) driver from the following URL.
> > > > >http://people.freebsd.org/~yongari/msk/e1000phy.c
> > > > >http://people.freebsd.org/~yongari/msk/e1000phyreg.h
> > > > >http://people.freebsd.org/~yongari/msk/miidevs
> > > > >
> > > > >OR get a jumbo patch for CURRENT.
> > > > >http://people.freebsd.org/~yongari/msk/e1000phy.patch
> > > >
> > > > I have tried your e1000phy patch as well as msk.diff.HEAD on an Acer
> > > > Aspire 5583 WXMi laptop:
> > > >
> > > > mskc0 at pci2:0:0: class=0x020000 card=0x01101025 chip=0x435211ab
> > > > rev=0x14 hdr=0x00
> > > > vendor = 'Marvell Semiconductor (Was: Galileo Technology Ltd)'
> > > > class = network
> > > > subclass = ethernet
> > > >
> > > > It seems that device_attach always returns 6 regardless
> > > > hw.pci.enable_msi[x]
> > > > is 1 or 0:
> > > >
> > >
> > > [...]
> > >
> > > > found-> vendor=0x11ab, dev=0x4352, revid=0x14
> > > > bus=2, slot=0, func=0
> > > > class=02-00-00, hdrtype=0x00, mfdev=0
> > > > cmdreg=0x0000, statreg=0x4010, cachelnsz=16 (dwords)
> > > > lattimer=0x00 (0 ns), mingnt=0x00 (0 ns), maxlat=0x00 (0 ns)
> > > > intpin=a, irq=10
> > > > powerspec 2 supports D0 D1 D2 D3 current D0
> > > > VPD Ident: Marvell Yukon 88E8038 Fast Ethernet Controller
> > > > PN: Yukon 88E8038
> > > > EC: Rev. 1.4
> > > > MN: Marvell
> > > > SN: AbCdEfG85BCA0
> > > > CP: id 1, BAR16, off 0x3cc
> > > > RV: 0x7d
> > > > MSI supports 2 messages, 64 bit
> > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > >
> > > Since Scott said resource allocation problem I'd like to say what
> > > I don't understand in this message.
> > >
> > > The motherboard I have also reports 2 MSI but I'm pretty sure the
> > > Yukon II hardware support only 1 MSI. If I force to call pci_alloc_msi()
> > > with 1 MSI it works without problems. At first, I thought my
> > > motherboard has chipset bug but I see the same 2 MSI message from
> > > your system.
> > >
> > > Does Youkon II really support 2 MSI?
> >
> > That's the hardware saying "I support 2 messages", so yes.
> >
>
> That's odd. I've read MSI control register with pci_read_config().
> It shows 0x11 as the control register value.
> As you said, it says the NIC support 2 messages but it could not.
> AFAIK bit 1-3 of the control register indicates the number of
> messages it supports which is 0(i.e. 1 message). Bit 4-6 defines
> number of messages allocated which is 2 so pci_msi_count() returns 2.
> However FreeBSD should not program MSI control register to support 2
> messages as it is not valid for this hardware!
>
> I've used the following code in device attach routine.
> if (pci_find_extcap(dev, PCIY_EXPRESS, ®) == 0) {
> printf("MSI capability!\n");
> reg = pci_read_config(dev, reg + PCIR_MSI_CTRL, 2);
> printf("MSI control = 0x%04x\n", reg);
> }
>
> What's your opinion? Should I ignore pci_msi_count() and do it
> myself to determine number of messages supported?
>
Oops, sorry. I've used incorrect capability. Please ignore this mail.
--
Regards,
Pyun YongHyeon
More information about the freebsd-current
mailing list