biodone panics
John Baldwin
jhb at FreeBSD.org
Thu Sep 29 11:07:01 PDT 2005
On Thursday 29 September 2005 03:17 am, Alex Lyashkov wrote:
> > > biodone(struct bio *bp)
> > > {
> > > void (*done)(struct bio *);
> > >
> > > mtx_lock(&bdonelock);
> > > bp->bio_flags |= BIO_DONE;
> > > done = bp->bio_done
> > > if (done == NULL)
> > > wakeup(bp);
> > > mtx_unlock(&bdonelock);
> > > if (done != NULL)
> > > bp->bio_done(bp);
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> posible it should be
> if(done != NULL)
> done(bp);
> ?
Note that since he only does the wakeup of done is NULL, so I think it's ok as
is.
--
John Baldwin <jhb at FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve" = http://www.FreeBSD.org
More information about the freebsd-current
mailing list