LOR #55 fix proposal (kern_descrip.c patch)

Roman Kurakin rik at cronyx.ru
Tue Sep 27 10:48:23 PDT 2005


Hi,

    It seems that the LOR #55 
(http://sources.zabbadoz.net/freebsd/lor.html#055)
could be fixed by following patch. I need testers and reviewers of it 
since I want
to commit it.

    I do not see a reason why not to extend action of FILEDESC_LOCK.

(http://www.cronyx.ru/~rik/freebsd/lor055/lor55.pch)

Index: kern_descrip.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v
retrieving revision 1.280
diff -u -r1.280 kern_descrip.c
--- kern_descrip.c      26 Aug 2005 11:16:39 -0000      1.280
+++ kern_descrip.c      27 Sep 2005 17:31:57 -0000
@@ -2275,7 +2275,6 @@
                        fdused(fdp, indx);
                if (fp != NULL)
                        FILE_LOCK(fp);
-               FILEDESC_UNLOCK(fdp);

                /*
                 * We now own the reference to fp that the ofiles[] array
@@ -2283,6 +2282,9 @@
                 */
                if (fp != NULL)
                        fdrop_locked(fp, td);
+
+               FILEDESC_UNLOCK(fdp);
+
                return (0);

        default:

Best regards,
                         rik



More information about the freebsd-current mailing list