panic: mutex nfsd_mtx owned at nfsserver/nfs_serv.c:2160

[Gleb Smirnoff]

On Wed, Oct 26, 2005 at 03:09:26PM +0200, Peter Holm wrote:
P> > On Wed, Oct 26, 2005 at 09:23:37AM +0200, Peter Holm wrote:
P> > P> While stress testing RELENG_6_0 with a nfs mounted file system on a 
P> > P> box running HEAD from Oct 24 13:21 UTC I got this panic (on HEAD):
P> > P> http://people.freebsd.org/~pho/stress/log/nfsd.html
P> > 
P> > let's try out this one.
P> > 
P> 
P> With this patch I got a (unrelated ?)
P> panic: lock (sleep mutex) Giant not locked @ nfsserver/nfs_serv.c:2193

Related. Please try out a corrected patch.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
-------------- next part --------------
Index: nfs_serv.c
===================================================================
RCS file: /home/ncvs/src/sys/nfsserver/nfs_serv.c,v
retrieving revision 1.156
diff -u -r1.156 nfs_serv.c
--- nfs_serv.c	17 Apr 2005 16:25:36 -0000	1.156
+++ nfs_serv.c	26 Oct 2005 13:13:25 -0000
@@ -2092,6 +2092,8 @@
 	tl = nfsm_dissect_nonblock(u_int32_t *, NFSX_UNSIGNED);
 	vtyp = nfsv3tov_type(*tl);
 	if (vtyp != VCHR && vtyp != VBLK && vtyp != VSOCK && vtyp != VFIFO) {
+		NFSD_UNLOCK();
+		mtx_lock(&Giant);	/* VFS */
 		error = NFSERR_BADTYPE;
 		goto out;
 	}
@@ -2108,6 +2110,8 @@
 	 * Iff doesn't exist, create it.
 	 */
 	if (nd.ni_vp) {
+		NFSD_UNLOCK();
+		mtx_lock(&Giant);	/* VFS */
 		error = EEXIST;
 		goto out;
 	}