Still at least one ATA problem

[Kevin Oberman]

> From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos at deepcore.dk>
> Date: Fri, 20 May 2005 07:42:25 +0200
> 
> 
> On 19/05/2005, at 23.56, Kevin Oberman wrote:
> 
> > S=F8ren,
> >
> > I have to take back my "everything works" message. :-(
> >
> > With a kernel built on 5/17 I can no longer detach my second ATA =20
> > channel.
> > # atacontrol list
> > ATA channel 0:
> >     Master:  ad0 <IC25N040ATCS05-0/CS4OA61A> ATA/ATAPI revision 5
> >     Slave:       no device present
> > ATA channel 1:
> >     Master:      no device present
> >     Slave:       no device present
> > # atacontrol detach 1
> > atacontrol: Invalid channel (null)
> >
> > It's not limited to the primary channel, either.
> > # atacontrol info 0
> > atacontrol: Invalid channel (null)
> 
> It still works, you need to type "atacontrol detach ata1" as the =20
> parsing is more tight now, and channel are "ataN" disks are "adN" =20
> etc, just as one would think if its wasn't for the old ways of no =20
> parsing at all (blaim POLA :) )

Yep. It works fine.

I think the man page needs updating. Here is a suggested update.
-- 
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman at es.net			Phone: +1 510 486-8634

-------------- next part --------------
--- atacontrol.8	Mon May 16 08:09:13 2005
+++ atacontrol.8.new	Fri May 20 09:27:35 2005
@@ -38,13 +38,13 @@
 .Pp
 .Nm
 .Ic attach
-.Ar channel
+.Ar controller
 .Nm
 .Ic detach
-.Ar channel
+.Ar controller
 .Nm
 .Ic reinit
-.Ar channel
+.Ar controller
 .Nm
 .Ic create
 .Ar type Oo Ar interleave Oc Ar disk0 ... diskN
@@ -65,7 +65,7 @@
 .Ar device
 .Nm
 .Ic info
-.Ar channel
+.Ar controller
 .Nm
 .Ic cap
 .Ar device
@@ -87,25 +87,26 @@
 exercise caution when using this command!
 .Pp
 The
-.Ar channel
-argument is the number of the ATA channel on which to operate.
+.Ar controller
+argument is the name of the ATA controller on which to operate. Ususally
+'ataN'.
 The following commands are supported:
 .Bl -tag -width "rebuild"
 .It Ic attach
 Attach an ATA
-.Ar channel .
-Devices on the channel are probed and attached as
+Ar controller .
+Devices on the controller are probed and attached as
 is done on boot.
 .It Ic detach
 Detach an ATA
-.Ar channel .
-Devices on the channel are removed from the kernel,
+.Ar controller .
+Devices on the controlller are removed from the kernel,
 and all outstanding transfers etc.\& are returned back to the system marked
 as failed.
 .It Ic reinit
 Reinitialize an ATA
-.Ar channel .
-Both devices on the channel are reset and
+.Ar controller .
+Both devices on the controller are reset and
 initialized to the parameters the ATA driver has stored internally.
 Devices that have gone bad and no longer respond to the probe, or devices
 that have physically been removed, are removed from the kernel.
@@ -192,7 +193,7 @@
 .Ar device .
 .It Ic info
 Show info about the attached devices on the
-.Ar channel .
+.Ar controller .
 .It Ic list
 Show info about all attached devices on all active controllers.
 .El