[TEST(/review)] major/minor/devname fix
Andrey Chernov
ache at nagual.pp.ru
Wed Mar 9 22:24:13 PST 2005
On Wed, Mar 09, 2005 at 10:40:18PM +0100, Poul-Henning Kamp wrote:
> +dev_t
> +dev2udev(struct cdev *x)
> +{
> + if (x == NULL)
> + return (NODEV);
> + return (x->si_inode ^ devfs_random());
> +}
...
> + dp = devfs_itod(ud ^ devfs_random());
Why you try to use randomization here instead of sequental ordering (or
reversing/shifting it)? In such small number of bits there is a big
probability of collisions may occurse.
--
http://ache.pp.ru/
More information about the freebsd-current
mailing list