[RFC] [PATCH] VM & VFS changes
Andre Guibert de Bruet
andy at siliconlandmark.com
Sun Jun 5 06:16:36 GMT 2005
On Sat, 4 Jun 2005, Jake Burkholder wrote:
> Andre Guibert de Bruet wrote:
>
>> Index: vm/swap_pager.c
>> ===================================================================
>> RCS file: /home/ncvs/src/sys/vm/swap_pager.c,v
>> retrieving revision 1.273
>> diff -u -r1.273 swap_pager.c
>> --- vm/swap_pager.c 20 May 2005 21:26:05 -0000 1.273
>> +++ vm/swap_pager.c 24 May 2005 02:21:30 -0000
>> @@ -2193,6 +2193,60 @@
>> return (error);
>> }
>>
> [...]
>> +
>> + mtx_lock(&sw_dev_mtx);
>> + TAILQ_REMOVE(&swtailq, sp, sw_list);
>> +
>> + sp = TAILQ_FIRST(&swtailq);
>> + free(sp, M_VMPGDATA);
>> + }
>>
> It looks like the free should be before sp = TAILQ_FIRST() instead of after.
Good catch! I did not catch this in my testing because I only have one
swapdev configured on my test machine. I will add this to my test plan.
Meanwhile, I updated the patch. I am still working on the other proposed
changes. I will probably keep this new version of the patch around for
reference when I make the "final" set of diffs available.
Thanks!
Andy
/* Andre Guibert de Bruet * 6f43 6564 7020 656f 2e74 4220 7469 6a20 */
/* Code poet / Sysadmin * 636f 656b 2e79 5320 7379 6461 696d 2e6e */
/* GSM: +1 734 846 8758 * 5520 494e 2058 6c73 7565 6874 002e 0000 */
/* WWW: siliconlandmark.com * Tormenting bytes since 1980. */
More information about the freebsd-current
mailing list