acpi battery rework patch
Marcin Jessa
lists at yazzy.org
Mon Jul 25 23:19:49 GMT 2005
On Mon, 25 Jul 2005 09:29:03 -0700
Nate Lawson <nate at root.org> wrote:
> Marcin Jessa wrote:
> > On Sun, 24 Jul 2005 17:15:12 -0700
> > Nate Lawson <nate at root.org> wrote:
> >>As far as Eric's result, I'll check that on my systems as well. I
> >>_think_ the previous behavior was more correct (-1 = unknown) so I'll
> >>commit this minor change. The "state" variable should not have changed
> >>so please let me know for sure if it has. "1" means "discharging" which
> >>doesn't sound right if you're on AC power. If you just recently plugged
> >>in the laptop, try polling the status a few more times (apm(8) gives
> >>more detail) and see if it catches up. Some systems lag reporting
> >>various values until they are sure they've restabilized after an AC line
> >>change.
> >>
> >>Marcin, if your system reports a valid rate of use, we can calculate
> >>time. If you're on AC power, there is no time available (since your
> >>batteries aren't discharging at any rate). Try a previous
> >>kernel/acpi.ko to be certain what the behavior used to be.
> >
> >
> > [yazzy at lapdance:~]> uname -a
> > FreeBSD lapdance.yazzy.net 6.0-BETA1 FreeBSD 6.0-BETA1 #4: Sat Jul 23 17:35:13 CEST 2005 root at lapdance.yazzy.net:/usr/obj/usr/src/sys/LAPDANCE-6.0 i386
> >
> > Running on AC:
> > [yazzy at lapdance:~]> sysctl -a | grep battery
> > hw.acpi.battery.life: 23
> > hw.acpi.battery.time: -1
> > hw.acpi.battery.state: 2
> > hw.acpi.battery.units: 1
> > hw.acpi.battery.info_expire: 5
> >
> > Running on battery:
> > [yazzy at lapdance:~]> sysctl -a | grep battery
> > hw.acpi.battery.life: 23
> > hw.acpi.battery.time: 41
> > hw.acpi.battery.state: 1
> > hw.acpi.battery.units: 1
> > hw.acpi.battery.info_expire: 5
> > [yazzy at lapdance:~]>
>
> And with a 7-current kernel, everything is the same except "time" is
> always -1 both on and off AC power?
>
> Please try this patch with 7-current and report its output both on and
> off power. It prints out more debugging info each time the battery is read.
>
> --
> Nate
>
Test results:
Running on 6.0-BETA1 #4: Sat Jul 23 17:35:13 CEST 2005
- AC:
hw.acpi.battery.life: 99
hw.acpi.battery.time: -1
hw.acpi.battery.state: 0
hw.acpi.battery.units: 1
hw.acpi.battery.info_expire: 5
- Battery:
hw.acpi.battery.life: 87
hw.acpi.battery.time: 103
hw.acpi.battery.state: 1
hw.acpi.battery.units: 1
hw.acpi.battery.info_expire: 5
Back on AC (notice battery.state changed to 2 from previous 0 on AC (charging) )
hw.acpi.battery.life: 86
hw.acpi.battery.time: -1
hw.acpi.battery.state: 2
hw.acpi.battery.units: 1
hw.acpi.battery.info_expire: 5
Running on FreeBSD 7.0-CURRENT #5: Mon Jul 25 22:21:05 CEST 2005 without the patch
- AC:
hw.acpi.battery.life: 100
hw.acpi.battery.time: -1
hw.acpi.battery.state: 0
hw.acpi.battery.units: 1
hw.acpi.battery.info_expire: 5
- Battery:
hw.acpi.battery.life: 99
hw.acpi.battery.time: 113
hw.acpi.battery.state: 1
hw.acpi.battery.units: 1
hw.acpi.battery.info_expire: 5
Running on FreeBSD 7.0-CURRENT #5: Mon Jul 25 22:21:05 CEST 2005 with the patch:
# sysctl -a | grep battery
- AC:
hw.acpi.battery.life: 70
hw.acpi.battery.time: -1
hw.acpi.battery.state: 2
hw.acpi.battery.units: 1
hw.acpi.battery.info_expire: 5
dev.battery.0.%desc: ACPI Control Method Battery
dev.battery.0.%driver: battery
dev.battery.0.%location: handle=\_SB_.PCI0.LPC_.EC__.BAT0
dev.battery.0.%pnpinfo: _HID=PNP0C0A _UID=0
dev.battery.0.%parent: acpi0
- Battery:
hw.acpi.battery.life: 70
hw.acpi.battery.time: 125
hw.acpi.battery.state: 1
hw.acpi.battery.units: 1
hw.acpi.battery.info_expire: 5
dev.battery.0.%desc: ACPI Control Method Battery
dev.battery.0.%driver: battery
dev.battery.0.%location: handle=\_SB_.PCI0.LPC_.EC__.BAT0
dev.battery.0.%pnpinfo: _HID=PNP0C0A _UID=0
dev.battery.0.%parent: acpi0
More information about the freebsd-current
mailing list