mss.c pcm fix to ' attach returned 6 ' load failure for v5.x
acpi and up
Nate Lawson
nate at root.org
Fri Jul 15 21:48:51 GMT 2005
Harry Coin wrote:
> At 02:28 PM 7/15/2005 -0700, Nate Lawson wrote:
>
>> Drivers should not rely on isa_get_logicalid() to determine a boolean
>> "is PNP?"
>
>
> The architecture manual specifies ISA_PNP_PROBE in non pnp ISA drivers
> for that purpose. As I understand it, John doesn't like the ugly nature
> of passing in a null device list for non-pnp ISA drivers. Hard to
> argue with that.
>
> So why not gin up a tiny little boolean kernel function
> 'device_is_pnp(dev)) ' that does the right thing for non-pnp isa drivers
> - once -,right after wherever ISA_PNP_PROBE is defined in the kernel?
I don't understand how this is needed. ACPI devices are always a
superset of PNP. If a probe method is not PNP capable, it should never
attach to the ACPI bus. I think that's what his fix changes, and I
think it's sufficient.
--
Nate
More information about the freebsd-current
mailing list