mss.c pcm fix to ' attach returned 6 ' load failure for v5.x
acpi and up
Nate Lawson
nate at root.org
Fri Jul 15 21:36:41 GMT 2005
John Baldwin wrote:
> On Monday 11 July 2005 06:23 pm, Nate Lawson wrote:
>
>>John Baldwin wrote:
>>
>>>Also, can you upload your acpidump somewhere and provide a URL? I'm
>>>curious if you have ACPI devices like thermal zones that don't have
>>>_HID's and only have _CIDs. In fact, here's a patch to fix
>>>acpi_get_logicalid() in that case. Give this a try first and let me know
>>>if it fixes it.
>>
>>I would rather you directly call acpi_isa_get_compatid() rather than
>>duplicating its logic here. There's no guarantee that the first CID
>>will match the single ID passed in.
>
>
> There is no passed in ID. For the common use of this function in almost all
> ISA drivers, it just needs to return != 0 for PNP devices.
I really think the driver is broken and the API is fine for this. I
don't like the hack of returning a random CID for checks against the
HID. Drivers down the road may come to rely on this and then every BIOS
that has a different order for CIDs becomes a potential breakage point.
Drivers should not rely on isa_get_logicalid() to determine a boolean
"is PNP?"
--
Nate
More information about the freebsd-current
mailing list