(problem found) grantpt broken on -CURRENT

[Joe Marcus Clarke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael L. Hostbaek wrote:
| Joe Marcus Clarke (marcus) writes:
|
|>On Wed, 2005-07-06 at 00:22 -0400, Joe Marcus Clarke wrote:
|>
|>>I created this patch that corrects the problem, but I'm not sure if it's
|>>the right way to go.  Poul-Henning (or anyone) could you have a look and
|>>let me know if this is okay?  I'd really like to see this working again
|>>in -CURRENT so 6.0 GNOME users will be able to use their sftp shares.
|>>Thanks.
|>>
|>>Oh, and it might be a good idea to make sys/types.h aware of MAXMINOR as
|>>it still hardcodes the constant.
|>
|>Actually, I think the real solution is to reimplement ptsname() using
|>devname(3) similar to the way ttyname() is done.
|
|
| I confirm that this patch (like the other), also fixes kio_sftp and
| kdesu on -CURRENT.

Actually, the first patch provided pty* names where as the previous
version of ptsname provided tty* device names.  The pty names break
gnome-vfs sftp.  This attached patch seems to do the trick for
gnome-vfs.  Michael, can you verify this patch still works for you?
Poul-Henning, thanks for your initial review.  Can you have a look at
this patch, and see if anything is glaringly wrong?  Thanks!

Joe

|
| Thanks !
|
| /mich
|
|


- --
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCy/9sb2iPiv4Uz4cRAtd8AJ0c9LBcyqCb6iAE20qxu3+k9wZ0aACgqRPH
CSFVX8X+TVDRm3F9Jne4mok=
=aPc4
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: grantpt.c.diff
Type: text/x-patch
Size: 835 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20050706/b0e0e267/grantpt.c.bin