USB problems

[Vladimir Grebenschikov]

В сб, 08/01/2005 в 02:03 +0300, Vladimir Grebenschikov пишет:
> В сб, 01/01/2005 в 02:11 -0800, Julian Elischer пишет:
> > Vladimir Grebenschikov wrote:
> > > В пт, 31/12/2004 в 05:05 -1000, Randy Bush пишет:
> > > 
> > >>possibly related?
> > >>
> > >>just so you know, on a thinkpad t41 with any current in the last
> > >>few weeks, i kernel panic on boot if a usb device is not plugged
> > >>in.  turning off acpi also allows boot.  see
> > >>
> > >>   <http://rip.psg.com/~randy/041215.crash>
> > >>
> > >>i can help debug if anyone is on the trail
> > > 
> > > 
> > > I have also problems with USB on recent current (previous was few weeks
> > > old).
> > > 
> > 
> > the most salient thiing you could do is find the date of the problem by checking 
> > out  sys/dev/usb on dec 9 and seeing if that fixes it (you said dec 9 was ok)
> > and if so, gradually moving it forward using a binary search and narrowing in on 
> > the commit that broke it.

I have found the exact reason - it stats fail after following patch:

sos         2004-12-08 11:16:33 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/ata          ata-queue.c 
  Log:
  Reset timeout when we are back from interrupt.
  
  Revision  Changes    Path
  1.41      +3 -0      src/sys/dev/ata/ata-queue.c


@@ -216,6 +216,9 @@
        ata_completed(request, 0);
     }
     else {
+       if (!dumping)
+           callout_reset(&request->callout, request->timeout * hz,
+                         (timeout_t*)ata_timeout, request);
        if (request->bio && !(request->flags & ATA_R_TIMEOUT)) {
            ATA_DEBUG_RQ(request, "finish bio_taskqueue");
            bio_taskqueue(request->bio, (bio_task_t *)ata_completed, request);

Looks like something bad happens with locking while this timeout.
With this patch reverse applied - all is ok.

Can anybody advise, what wrong happens there with locking ?

(original panic description in attachment)

This panic happens after ATA initialization. But If I boot with plugged USB hub (it has keyboard and mouse)
I've get panic on ATAPICAM init.


Should I fill PR ?

(last try with very last current)

-- 
Vladimir B. Grebenchikov
vova at fbsd.ru
-------------- next part --------------
An embedded message was scrubbed...
From: Vladimir Grebenschikov <vova at fbsd.ru>
Subject: Re: USB problems
Date: Sat, 01 Jan 2005 04:15:38 +0300
Size: 7325
Url: http://lists.freebsd.org/pipermail/freebsd-current/attachments/20050115/6d4b3c28/attachment.mht