netgraph(3) initialization order

[Roman Kurakin]

Maksim Yevmenkin:

> Dear Hackers,
>
> would anyone object if i change SI_ORDER_MIDDLE in the 
> /sys/netgraph/ng_base.c:2994 to say SI_ORDER_THIRD, i.e.
>
> change
>
> DECLARE_MODULE(netgraph, netgraph_mod, SI_SUB_DRIVERS, SI_ORDER_MIDDLE);
>
> to
>
> DECLARE_MODULE(netgraph, netgraph_mod, SI_SUB_DRIVERS, SI_ORDER_THIRD);
>
> the reason for this change is that bluetooth device drivers depend on 
> netgraph(4) and when both netgraph(4) and bluetooth device driver 
> (such as ng_ubt(4)) compiled in the kernel you get a crash. basically 
> ng_ubt(4) mod_load callback is called before netgraph(4) mod_load 
> callback and ng_findtype() crashes on uninitialized mutex 
> (DEVICE_MODULE macro passes SI_SUB_DRIVERS, SI_ORDER_THIRD to the 
> DECLARE_MODULE). 

I thought this is the task of MODULE_DEPEND.

rik

> option #2 would be to have DEVICE_MODULE_ORDERED macro which accepts 
> two extra parameters.
>
>
> and finally option #3 would be to duplicate entire content of the 
> DEVICE_MODULE macro in all bluetooth device drivers and specify order 
> in DECLARE_MODULE macro.
>
>
> any thoughts?
>
> thanks,
> max
> _______________________________________________
> freebsd-current at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to 
> "freebsd-current-unsubscribe at freebsd.org"