Giant around fdfree() in exit1() ?

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Aug 17 09:13:43 GMT 2005


I'm seeing Giant held in a MNTK_MPSAFE devfs->close without this patch,
any insight/comments ?

Index: kern/kern_exit.c
===================================================================
RCS file: /home/ncvs/src/sys/kern/kern_exit.c,v
retrieving revision 1.264
diff -u -r1.264 kern_exit.c
--- kern/kern_exit.c	18 Jul 2005 20:08:14 -0000	1.264
+++ kern/kern_exit.c	17 Aug 2005 08:42:38 -0000
@@ -229,13 +229,13 @@
 	 */
 	mtx_lock(&Giant);	/* XXX: not sure if needed */
 	funsetownlst(&p->p_sigiolst);
+	mtx_unlock(&Giant);	
 
 	/*
 	 * Close open files and release open-file table.
 	 * This may block!
 	 */
 	fdfree(td);
-	mtx_unlock(&Giant);	
 
 	/*
 	 * If this thread tickled GEOM, we need to wait for the giggling to
-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.


More information about the freebsd-current mailing list