Locking fixes for dc(4): please test!

Marcel Moolenaar marcel at xcllnt.net
Fri Aug 12 04:37:59 GMT 2005


On Aug 11, 2005, at 2:22 PM, John Baldwin wrote:

>> ds10% cd /sys/alpha/compile/DS10
>> ds10% make
>> cc -c -O -pipe -mcpu=ev6 -mieee -Wall -Wredundant-decls -Wnested-
>> externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -
>> Winline -Wcast-qual  -fformat-extensions -std=c99 -g -nostdinc -I-  -
>> I. -I../../.. -I../../../contrib/dev/acpica -I../../../contrib/altq -
>> I../../../contrib/ipfilter -I../../../contrib/pf -I../../../contrib/
>> dev/ath -I../../../contrib/dev/ath/freebsd -I../../../contrib/ngatm -
>> I../../../dev/twa -D_KERNEL -include opt_global.h -fno-common -
>> finline-limit=15000 --param inline-unit-growth=100 --param large-
>> function-growth=1000  -mno-fp-regs -ffixed-8 -Wa,-mev6 -ffreestanding
>> -Werror  ../../../pci/if_dc.c
>> ../../../pci/if_dc.c: In function `dc_init':
>> ../../../pci/if_dc.c:3407: error: `ifp' undeclared (first use in this
>> function)
>> ../../../pci/if_dc.c:3407: error: (Each undeclared identifier is
>> reported only once
>> ../../../pci/if_dc.c:3407: error: for each function it appears in.)
>> ../../../pci/if_dc.c:3407: error: `mii' undeclared (first use in this
>> function)
>> *** Error code 1
>>
>> ...The SRM_MEDIA macro is probably only defined on alpha...
>>
>
> Yeah it is, which is why I wanted someone with an Alpha to test  
> it.  You
> should be able to replace 'ifp' with 'sc->dc_ifp' on line 3407.   
> I'll fix the
> patch and re-upload it as well.  Thanks.

Yup, that fixes half the problems. I added the following at line 3403
to fix the other half:

     struct mii_data *mii;
     mii = device_get_softc(sc->dc_miibus);

With that, if_dc seems to work fine. haven't pushed it though...
FYI,

-- 
  Marcel Moolenaar         USPA: A-39004          marcel at xcllnt.net




More information about the freebsd-current mailing list