[PATCH] Allow watching of vnodes that reside on non-UFS filesystems with kqueue

John-Mark Gurney gurney_j at resnet.uoregon.edu
Tue Apr 12 22:40:23 PDT 2005


Suleiman Souhlal wrote this message on Tue, Apr 12, 2005 at 23:05 -0400:
> Hello,
> 
> The patch at 
> http://people.freebsd.org/~ssouhlal/testing/kqueue-hooks-20050412.diff 
> allows watching vnodes on non-UFS filesystems with kqueue.
> 
> It moves the VN_KNOTE calls to pre and post VOP_* hooks. These hooks 
> are currently used for VFS lock debugging only, but I made them 
> unconditional. I think that they we could eventually move the 
> mac_check_vnode_* calls into them too, with a bit of work.
> 
> I would like to commit this to HEAD, if there are no objections.

I would prefer to move the vfs_kqfilter and filt_vfs* functions either
be moved to a vfs specific file, or be moved to their own file..  also,
it appears that we lost support for extending of files... though I can't
confirm that...  Have you verified that extending still gets notified?

Other wise looks good...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."


More information about the freebsd-current mailing list