smbfs bug introduced at smbfs_vnops.c:1.58

[Ulrich Spoerlein]

On Sun, 10.04.2005 at 13:08:36 +0200, Jens Schweikhardt wrote:
> # The compiler should warn about this. But something fishy is going on ...
> # 
> # foo.c:
> # int main(void) {
> #   int a;
> #   a+=1;
> #   return (0);
> # }
> 
> Not so fishy. No warning because -O completely optimizes 'a' away. Try
> this instead:
> 
> $ cat foo.c
> int main(void) {
>   int a;
>   a+=1;
>   return a;
> }
> $ gcc -O -W -Wall -Wuninitialized -Winit-self foo.c
> foo.c: In function `main':
> foo.c:2: warning: 'a' might be used uninitialized in this function

True, but the compiler should warn about bogus source code, even if the
resulting object code (depending on optmiziation flags) is valid.

IMHO

Let's get back to the bug in smbfs_vnops.c, did the compiler issue a
warning?

Ulrich Spörlein
-- 
 PGP Key ID: F0DB9F44				Encrypted mail welcome!
Fingerprint: F1CE D062 0CA9 ADE3 349B  2FE8 980A C6B5 F0DB 9F44
Ok, which part of "Ph'nglui mglw'nafh Cthulhu R'lyeh wgah'nagl fhtagn."
didn't you understand?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20050410/3bf87297/attachment.bin