trap: page fault after shutdown (irq23: vr0)

[Bruce M Simpson]

Hi,

On Tue, Oct 19, 2004 at 02:56:37PM +0200, Sebastian Schulze Struchtrup wrote:
> I have not noticed this before BETA4. I am currently running 5.3 STABLE/RC1.
> The trap occurs in process "irq23: vr0". I am not sure if this is 
> related to vr0. The code for vr (sys/pci/if_vr.c) has not changed since 

This is a duplicate of kern/62889.
vr_shutdown() is incorrect and in fact prone to race on SMP.

I've committed a fix to current. Patch is attached.
MFC request to RELENG_5 and RELENG_5_3 is pending.

Regards,
BMS
-------------- next part --------------
Index: if_vr.c
===================================================================
RCS file: /home/ncvs/src/sys/pci/if_vr.c,v
retrieving revision 1.94
diff -u -p -r1.94 if_vr.c
--- if_vr.c	11 Aug 2004 04:30:49 -0000	1.94
+++ if_vr.c	19 Oct 2004 15:22:08 -0000
@@ -1692,7 +1692,5 @@ vr_shutdown(device_t dev)
 {
 	struct vr_softc		*sc = device_get_softc(dev);
 
-	VR_LOCK(sc);
-	vr_stop(sc);
-	VR_UNLOCK(sc);
+	vr_detach(sc);
 }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 167 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20041019/6a47c2e6/attachment.bin