No booting - ata1-slave: FAILURE

[Søren Schmidt]

Jochen Gensch wrote:
> Hi,
> 
> I just cvsup'd RELENG_5 and the system is not booting any more with the 
> new kernel. It hangs at the ata identifying with the message:
> 
> ata1-slave: FAILURE - ATAPI_IDENTIFY timed out
> 
> I am using the GENERIC kernel, the only additional thing in there is 
> atapicam. Maybe I just cvsup'd  at a bad time :-) ?

Maybe not, could you please try the attached patch and let me know if 
that helps or not ?

-- 

-Søren

-------------- next part --------------
Index: ata-all.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-all.c,v
retrieving revision 1.222.2.4
diff -u -r1.222.2.4 ata-all.c
--- ata-all.c	16 Oct 2004 08:43:06 -0000	1.222.2.4
+++ ata-all.c	17 Oct 2004 16:38:21 -0000
@@ -306,6 +306,12 @@
 	}
     }
 
+    ch->flags &= ~ATA_IMMEDIATE_MODE;
+    mtx_lock(&ch->state_mtx);
+    ch->state = ATA_IDLE;
+    mtx_unlock(&ch->state_mtx);
+    ch->locking(ch, ATA_LF_UNLOCK);
+
     /* attach new devices */
     if ((newdev = ~devices & ch->devices)) {
 	if ((newdev & (ATA_ATA_MASTER | ATA_ATAPI_MASTER)) &&
@@ -323,12 +329,6 @@
     if (bootverbose)
 	ata_printf(ch, -1, "device config done ..\n");
 
-    ch->flags &= ~ATA_IMMEDIATE_MODE;
-    mtx_lock(&ch->state_mtx);
-    ch->state = ATA_IDLE;
-    mtx_unlock(&ch->state_mtx);
-    ch->locking(ch, ATA_LF_UNLOCK);
-
     ata_start(ch);
     return 0;
 }