Traffic Shaping not working correctly after ipfw coverted to use pfil_hooks API

[Nikolay Pavlov]

Hi, Vincent.

On Thursday, 28 October 2004 at 17:19:43 -0700, Vincent Poy wrote:
> # Assign outgoing empty/small ACK packets to the high-priority queue
> ${fwcmd} add 63004 set 0 queue 1 tcp from any to any tcpflags ack out

Dummynet works as well as should, but if I have correctly undestood your
idea this rule should be something like this:
${fwcmd} add 63004 set 0 queue 1 tcp from any to any tcpflags ack out iplen 1-66 

> 
> It appears that somehow the ACKs were not sent with priority on the
> upload pipe while downloading which is slowing the download side to
> less than 33% speed of the pipe.

I think you missundestood appointment of this flag. If you use tcpdump
you will see, that packet with ack flag in time of uploading often contains
also the data, instead of simply short answer with acknowledgment. So that 
booster is not correctly adjusted. See my comment above.

> Here are the ipfw pipe and queue's:
> 
> root at bigbang [5:11pm][/home/vince] >> ipfw pipe show
> 00001: 400.000 Kbit/s    0 ms   50 sl. 0 queues (1 buckets) droptail
>     mask: 0x00 0x00000000/0x0000 -> 0x00000000/0x0000
> q00001: weight 100 pipe 1   50 sl. 1 queues (1 buckets) droptail
>     mask: 0x00 0x00000000/0x0000 -> 0x00000000/0x0000
> BKT Prot ___Source IP/port____ ____Dest. IP/port____ Tot_pkt/bytes Pkt/Byte Drp
>   0 tcp  208.201.244.226/1449    64.12.185.119/80    96816 57368081 39 13603 311

This is just confirmation of my words.
Hope this help.

Best regards,
	Nikolay Pavlov.