ACPI breakage

[Nate Lawson]

On Sat, 22 May 2004, Tim Robbins wrote:
> On Sat, May 22, 2004 at 01:15:05AM +1000, Tim Robbins wrote:
> > On Fri, May 21, 2004 at 10:43:01AM -0400, John Baldwin wrote:
> >
> > > On Friday 21 May 2004 07:21 am, Tim Robbins wrote:
> > > > Hi,
> > > >
> > > > On trying to boot a recent CURRENT kernel on one of my machines (i386
> > > > kernel, Pentium III (Katmai) 500 MHz CPU, Abit BH6 motherboard), I get a
> > > > panic: ...
> > > > pcib1: <PCI-PCI bridge> at device 1.0 on pci0
> > > > pci1: <ACPI PCI bus> on pcib1
> > > > pcib0: slot 1 INTA is routed to irq 12
> > > > pcib1: slot 0 INTA is routed to irq 12
> > > >
> > > > Fatal trap 12: page fault while in kernel mode
> > > > fault virtual address = 0x15
> > >
> > > You shouldn't have an ACPI PCI bus as the child of a PCI bus.  What happens if
> > > you revert rev 1.65 of sys/dev/acpica/acpivar.h?
> >
> > It turns out that I reverted acpivar.h to rev. 1.64 when I reverted
> > acpi_ec.c to 1.47. I'll try acpi_ec.c 1.49 + acpivar.h 1.64 and report
> > back on the results.
>
> Just following up on this: I built two otherwise identical kernels, one with
> acpivar.h revision 1.64, and one with revision 1.65. The kernel with 1.64
> worked fine, but the kernel with 1.65 panicked while probing PCI busses.

Reverted.  Thanks to you and peadar@ for testing this.  I'm sorry I didn't
address this earlier (was out of town).  The EC should be fine but the bus
accessor macros were not correct.  I'm very sorry to cause this trouble.

-Nate