RELENG_5_2 doesnt compile

[Scott Long]

Lukas Ertl wrote:
> On Wed, 10 Mar 2004, Scott Long wrote:
> 
> 
>>Divacky Roman wrote:
>>
>>>HI
>>>
>>>freshly cvsuped RELENG_5_2 doesnt compile in vinum.c
>>>in function vinumattach:136,143,150,162
>>>
>>>p_intr_nesting_level not being member of a structure.
>>>
>>>roman
>>
>>
>>It looks like compiling vinum without VINUMDEBUG triggers this.  Since
>>the module uses VINUMDEBUG, and LINT uses VINUMDEBUG, and vinum isn't
>>enabled in GENERIC, this wasn't detected.  Hopefully one of the vinum
>>maintainers can look into this and correct it.
> 
> 
> I'm not quite sure what's wrong here.  Did you compile vinum into the
> kernel?  Obviously the comment in sys/conf/NOTES is wrong, you must set
> VINUMDEBUG to match the value in sys/modules/vinum/Makefile.
> 
> regards,
> le
> 

If you try compiling vinum (either as a module or in the kernel) without
setting the VINUMDEBUG option, it will fail.  The 'Malloc' macro in
vinumext.h gropes around in td_proc (strike 1) for a field that no
longer exists (strike 2), but only does this in the non-VINUMDEBUG case
(strike 3).


Scott