Network driver jumbo patch (affects multicast)
mux at freebsd.org
Thu Jun 3 14:29:44 GMT 2004
Christian Weisgerber wrote:
> Andrew Thompson:
> > You have removed the following comment from if_xl.c. The two notes are
> > still relevant, should they stay?
> > - * Note: the 3c905B currently only supports a 64-bit hash table,
> > - * which means we really only need 6 bits, but the manual indicates
> > - * that future chip revisions will have a 256-bit hash table,
> > - * hence the routine is set up to calculate 8 bits of position
> > - * info in case we need it some day.
> > - * Note II, The Sequel: _CURRENT_ versions of the 3c905B have a
> > - * 256 bit hash table. This means we have to use all 8 bits regardless.
> > - * On older cards, the upper 2 bits will be ignored. Grrrr....
> I think it's just rambling.
I tend to disagree, I find this comment a valuable technical information.
This is one very cool thing with Bill Paul drivers, they are very well
commented, and I don't think we should change that. At the very least,
this change should be separate to the one that uses the new multicast
More information about the freebsd-current